fix: graceful error on non-UTF-8 --time-style value instead of panic#1840
Open
SAY-5 wants to merge 1 commit into
Open
fix: graceful error on non-UTF-8 --time-style value instead of panic#1840SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
eza --time-style VALUEaborted with a panic (exit 134) whenVALUEwas not valid UTF-8, e.g.eza --time-style "$(printf '\xff\xfe')" .. The customTimeFormatParser::parse_refcalledvalue.to_str().unwrap(), andOsStr::to_str()returnsNonefor non-UTF-8, so the.unwrap()panicked.This makes the parser return a clap
InvalidUtf8usage error when the value is not valid UTF-8, matching how every other flag rejects bad input. The sibling env-var path inview.rsalready handles this withto_str().unwrap_or("").Fixes #1837.
How Has This Been Tested?
cargo test --libpasses, including a new#[cfg(unix)]regression test that feeds a non-UTF-8--time-stylevalue and asserts a usage error rather than a panic. Manually confirmedeza --time-style "$(printf '\xff\xfe')" .now printserror: invalid UTF-8 in --time-style valueinstead of crashing.cargo fmtandcargo clippy --libare clean.