fix(theme): honor XDG_CONFIG_HOME for theme lookup#1810
Open
ming-hao-xu wants to merge 1 commit into
Open
Conversation
ming-hao-xu
force-pushed
the
fix-honor-xdg-config-home-for-theme
branch
4 times, most recently
from
0c8e3fa to
0573016
Compare
ming-hao-xu
force-pushed
the
fix-honor-xdg-config-home-for-theme
branch
from
0573016 to
33f4f36
Compare
Author
|
knock knock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1224.
This updates theme lookup to use
EZA_CONFIG_DIRfirst, then$XDG_CONFIG_HOME/ezawhenXDG_CONFIG_HOMEis set to an absolute path, and finally the platform config directory as the fallback.That keeps the platform-native fallback on macOS, while honoring an explicitly configured
XDG_CONFIG_HOMEfor users who keep their eza config under~/.config/eza.This also fixes the default
theme.ymlbranch to load the discovered file path instead of returningThemeConfig::default(), matching the existingtheme.yamlbehavior.How Has This Been Tested?
Reproduced the current macOS lookup behavior with temporary
XDG_CONFIG_HOMEandEZA_CONFIG_DIRdirectories using eza v0.23.4.Added unit coverage for
EZA_CONFIG_DIR,XDG_CONFIG_HOME, empty and relativeXDG_CONFIG_HOME, and precedence.CI covers the full formatting, lint, build, and test matrix on the PR.