Skip to content

Add video playback progress overlay#1790

Open
kanihal wants to merge 3 commits into
extesy:masterfrom
kanihal:codex/playback-progress-bar
Open

Add video playback progress overlay#1790
kanihal wants to merge 3 commits into
extesy:masterfrom
kanihal:codex/playback-progress-bar

Conversation

@kanihal

@kanihal kanihal commented Jun 22, 2026

Copy link
Copy Markdown

Summary

  • Add a bottom overlay progress bar for zoomed videos
  • Show elapsed and total playback time when media duration is available
  • Hide the progress overlay for streams/media without a finite duration

Validation

  • node --check js/hoverzoom.js
  • git diff --check -- js/hoverzoom.js

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a playback progress bar overlay for video elements in HoverZoom, including custom CSS styling, a time formatting helper, and event-driven updates. The review feedback highlights a potential memory leak and redundant execution issue caused by registering duplicate event listeners on the same video element when addPlaybackProgress is called multiple times. A fix is suggested to clean up previously registered listeners before adding new ones.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread js/hoverzoom.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants