feat(tests): EIP-8037 calldata floor binds with an over-cap reservoir#3080
Open
chfast wants to merge 1 commit into
Open
feat(tests): EIP-8037 calldata floor binds with an over-cap reservoir#3080chfast wants to merge 1 commit into
chfast wants to merge 1 commit into
Conversation
A tx with large floor-binding calldata and gas_limit > TX_MAX_GAS_LIMIT does an SSTORE-set funded from the reservoir. The EIP-7976 floor is the sender's bill (receipt cumulative_gas_used = floor), while the block accounts regular and state separately: block-regular excludes the floor, so the header gas_used is the state dimension (97_920), not the floor. Also fix the stale module docstring that claimed block-regular uses max(tx_regular, floor); the spec/impl apply the floor only to the sender's charge (fork.py:1095 vs :1135).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3080 +/- ##
================================================
Coverage 93.22% 93.22%
================================================
Files 624 624
Lines 36936 36936
Branches 3377 3377
================================================
Hits 34433 34433
Misses 1709 1709
Partials 794 794
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
A tx with large floor-binding calldata and gas_limit > TX_MAX_GAS_LIMIT does an SSTORE-set funded from the reservoir. The EIP-7976 floor is the sender's bill (receipt cumulative_gas_used = floor), while the block accounts regular and state separately: block-regular excludes the floor, so the header gas_used is the state dimension (97_920), not the floor.
Also fix the stale module docstring that claimed block-regular uses max(tx_regular, floor); the spec/impl apply the floor only to the sender's charge (fork.py:1095 vs :1135).
🔗 Related Issues or PRs
N/A.
✅ Checklist
just static<type>(<area>):, where<type>and<area>come from an approrpriateC-<type>, respectivelyA-<area>, label. The title should match the a target squash commit message../tests/ported_static/: