Open
Conversation
The aria-hidden="true" attribute was hidding the whole main navigation menu for screen readers, making it inaccessible for blind and visually impaired users. In mobile view, the menu was accessible thanks to .nav-main-mobile, which is hidden with display:none in desktop view (making it also hidden for screen readers).
The <nav> element is meant to be used for navigation links, such as menus, breadcrumbs, tables of contents…
Test Results 1 files 1 suites 0s ⏱️ For more details on these errors, see this check. Results for commit 55d0a31. ♻️ This comment has been updated with latest results. |
|
🔎 Download the Backstop report for this pull request (link valid for 90 days): |
|
|
||
| <form action="#" class="d-xl-none"> | ||
| <a id="search-mobile-toggle" class="search-mobile-toggle searchform-controller" href="#"> | ||
| <button id="search-mobile-toggle" class="search-mobile-toggle searchform-controller"> |
Member
There was a problem hiding this comment.
En l'état, le type button va soumettre le formulaire (au lieu d'afficher la barre de recherche).
|
|
||
| <div class="dropdown dropright search d-none d-xl-block"> | ||
| <a class="dropdown-toggle" href="#" data-toggle="dropdown"> | ||
| <button class="dropdown-toggle" href="#" data-toggle="dropdown"> |
Member
There was a problem hiding this comment.
Est-ce que le href est nécessaire ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aria-hidden="true"sur l'élément.nav-header, qui masquait l’ensemble du menu de navigation principale pour les lecteurs d'écran utilisés par les personnes aveugles ou malvoyantes.<nav>autour du menu principal.<div>, pas dans un<nav>.<button>plutôt que<a>pour le bouton qui sert à afficher le champ de recherche, et ajout d'un nom accessible masqué.https://epfl-webvolution.atlassian.net/browse/WEBEVOL-225