Use status matchers where appropriate (15)#46245
Open
ravenblackx wants to merge 5 commits into
Open
Conversation
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Signed-off-by: Raven Black <ravenblack@dropbox.com>
ravenblackx
marked this pull request as ready for review
July 17, 2026 21:31
ravenblackx
requested review from
KBaichoo,
mattklein123,
tonya11en and
wbpcode
as code owners
July 17, 2026 21:31
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Use status matchers where appropriate (14)
Additional Description: Part of a wide cleanup of status-related expectations - EXPECT_TRUE and EXPECT_FALSE have unhelpful output on test failure compared to the actual status matchers, and in some cases are less readable. A cleanup of this pattern will tend to also improve future code.
Risk Level: test-only
Note: AI (Codex 5.6) was used to generate this set of PRs; I have reviewed each PR manually before marking it ready for review.