Skip to content

http: add server factory only factory support to dynamic_forward_proxy#46222

Open
wbpcode wants to merge 1 commit into
envoyproxy:mainfrom
wbpcode:route-factory-dynamic-forward-proxy
Open

http: add server factory only factory support to dynamic_forward_proxy#46222
wbpcode wants to merge 1 commit into
envoyproxy:mainfrom
wbpcode:route-factory-dynamic-forward-proxy

Conversation

@wbpcode

@wbpcode wbpcode commented Jul 17, 2026

Copy link
Copy Markdown
Member

Commit Message: http: add server factory only factory support to dynamic_forward_proxy
Additional Description:
This adds the server-factory-context-only filter factory creation method
(createHttpFilterFactoryFromProtoTyped taking only a ServerFactoryContext,
introduced in #45989) to the dynamic_forward_proxy HTTP filter(s).

This allows these filters to be created in contexts where only a
ServerFactoryContext is available (e.g. route/virtual-host level filter
configuration) rather than requiring the full downstream FactoryContext.
The existing downstream FactoryContext path is preserved and now delegates
to a shared helper, so behavior for existing use cases is unchanged.

Generative AI was used to assist with this change. I have reviewed all changes.
Risk Level: Low
Testing: Existing/added unit config tests; CI.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

@repokitteh-read-only

Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #46222 was opened by wbpcode.

see: more, trace.

@wbpcode
wbpcode force-pushed the route-factory-dynamic-forward-proxy branch from 8bf50fb to a27f68d Compare July 18, 2026 08:26
@wbpcode
wbpcode marked this pull request as ready for review July 18, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants