Skip to content

http: add server factory only factory support to compressor, transform and proto_api_scrubber#46220

Open
wbpcode wants to merge 3 commits into
envoyproxy:mainfrom
wbpcode:route-factory-compressor-transform-scrubber
Open

http: add server factory only factory support to compressor, transform and proto_api_scrubber#46220
wbpcode wants to merge 3 commits into
envoyproxy:mainfrom
wbpcode:route-factory-compressor-transform-scrubber

Conversation

@wbpcode

@wbpcode wbpcode commented Jul 17, 2026

Copy link
Copy Markdown
Member

Commit Message: http: add server factory only factory support to compressor, transform and proto_api_scrubber
Additional Description:
This adds the server-factory-context-only filter factory creation method
(createHttpFilterFactoryFromProtoTyped taking only a ServerFactoryContext,
introduced in #45989) to the compressor, transform and proto_api_scrubber HTTP filter(s).

This allows these filters to be created in contexts where only a
ServerFactoryContext is available (e.g. route/virtual-host level filter
configuration) rather than requiring the full downstream FactoryContext.
The existing downstream FactoryContext path is preserved and now delegates
to a shared helper, so behavior for existing use cases is unchanged.

Generative AI was used to assist with this change. I have reviewed all changes and also did some manually update.

Risk Level: Low
Testing: Existing/added unit config tests; CI.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

@repokitteh-read-only

Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #46220 was opened by wbpcode.

see: more, trace.

…orm, proto_api_scrubber

Signed-off-by: wbpcode <wbphub@gmail.com>
@wbpcode
wbpcode force-pushed the route-factory-compressor-transform-scrubber branch from 1f7c6fb to c1436ef Compare July 17, 2026 13:30
… route-factory-compressor-transform-scrubber
@wbpcode
wbpcode marked this pull request as ready for review July 17, 2026 13:32
@yanavlasov

Copy link
Copy Markdown
Contributor

Build failures seem legit.

/wait

Signed-off-by: wbpcode <wbphub@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants