http: add server factory only factory support to cache#46218
Open
wbpcode wants to merge 1 commit into
Open
Conversation
Signed-off-by: wbpcode <wbphub@gmail.com>
wbpcode
force-pushed
the
route-factory-cache
branch
from
July 18, 2026 09:16
ca5f5bd to
0bc1a49
Compare
wbpcode
marked this pull request as ready for review
July 18, 2026 09:16
wbpcode
commented
Jul 18, 2026
Comment on lines
322
to
+323
| getCache(const envoy::extensions::filters::http::cache::v3::CacheConfig& config, | ||
| Server::Configuration::FactoryContext& context) PURE; | ||
| Server::Configuration::ServerFactoryContext& context) PURE; |
Member
Author
There was a problem hiding this comment.
This also may break forks but it's should be fine because:
- Cache still in WIP status.
- All existing getCache implementation will return a singleton which will be shared across listeners, it would be better to use server factory context here.
Member
Author
|
I actually don't know if this necessary after we had cache v2. But this change is simple and almost similar with cache v2. So, I still create a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: http: add server factory only factory support to cache
Additional Description:
This adds the server-factory-context-only filter factory creation method
(
createHttpFilterFactoryFromProtoTypedtaking only aServerFactoryContext,introduced in #45989) to the cache HTTP filter(s).
This allows these filters to be created in contexts where only a
ServerFactoryContextis available (e.g. route/virtual-host level filterconfiguration) rather than requiring the full downstream
FactoryContext.The existing downstream
FactoryContextpath is preserved and now delegatesto a shared helper, so behavior for existing use cases is unchanged.
Generative AI was used to assist with this change. I have reviewed all changes.
Risk Level: Low
Testing: Existing/added unit config tests; CI.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A