Remove rustls-pemfile dependency
#5339
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
56067f9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://52f628af.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://devon-remove-rustls-pemfile.matrix-authentication-service-docs.pages.dev |
devonh
added
the
T-Task
anoadragon453
approved these changes
Dec 10, 2025
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Looks like we're just replacing methods to read the same keys. And the original advisory recommended we use this alternative dependency (which itself was used by rustls-pemfile.
This all looks sound to me. I requested a review from @element-hq/security out of paranoia in case there's some unknown unknown while dealing with certificates. For context, this code sets up TLS certificates for MAS workers (used here).
sandhose
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5337
Removes the
rustls-pemfiledependency and replaces it's usage withrustls-pki-types.