Skip to content

Conversation

@balegas
Copy link
Contributor

@balegas balegas commented Dec 5, 2025

We're dropping the publication when we drop the replication slot on restart and shutdown. We should never drop the publication when manual_table_publishing is set to avoid resetting any filters the user has set.

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.21%. Comparing base (03c10a2) to head (474a045).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3556      +/-   ##
==========================================
- Coverage   75.36%   75.21%   -0.15%     
==========================================
  Files          51       51              
  Lines        2744     2744              
  Branches      404      408       +4     
==========================================
- Hits         2068     2064       -4     
- Misses        674      678       +4     
  Partials        2        2              
Flag Coverage Δ
electric-telemetry 22.71% <ø> (ø)
elixir 57.38% <ø> (-0.36%) ⬇️
elixir-client 73.94% <ø> (-0.53%) ⬇️
packages/experimental 87.73% <ø> (ø)
packages/react-hooks 86.48% <ø> (ø)
packages/typescript-client 93.08% <ø> (ø)
packages/y-electric 55.12% <ø> (ø)
typescript 87.46% <ø> (ø)
unit-tests 75.21% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants