feat: added support for move tags on the shape class #3524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icehaunter
changed the title
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3524 +/- ##
===========================================
- Coverage 75.35% 61.64% -13.72%
===========================================
Files 51 40 -11
Lines 2743 1559 -1184
Branches 408 106 -302
===========================================
- Hits 2067 961 -1106
+ Misses 674 597 -77
+ Partials 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
icehaunter
force-pushed
the
ilia/pr/kvspxstnvpqo
branch
from
ee45196 to
5026ac5
Compare
icehaunter
force-pushed
the
ilia/pr/oprpsyywvtqt
branch
2 times, most recently
from
491b3ba to
044b324
Compare
icehaunter
force-pushed
the
ilia/pr/kvspxstnvpqo
branch
3 times, most recently
from
22e28c3 to
176006c
Compare
icehaunter
force-pushed
the
ilia/pr/oprpsyywvtqt
branch
from
044b324 to
77588f6
Compare
icehaunter
force-pushed
the
ilia/pr/kvspxstnvpqo
branch
from
176006c to
3aa5d00
Compare
icehaunter
force-pushed
the
ilia/pr/oprpsyywvtqt
branch
from
77588f6 to
61a0dce
Compare
icehaunter
force-pushed
the
ilia/pr/oprpsyywvtqt
branch
from
61a0dce to
5ba9884
Compare
kevin-dp
approved these changes
Dec 1, 2025
| ) | ||
| } | ||
| // Set new tags | ||
| const newTags = new Set(message.headers.tags) |
Contributor
There was a problem hiding this comment.
More efficient to add the incoming tags and remove only the removed_at tags instead of first removing all tags and then adding the new tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.