Replace deprecated JSON.fast_generate with JSON.generate#1552
Open
pascaltozzi wants to merge 1 commit intoelastic:mainfrom
Open
Replace deprecated JSON.fast_generate with JSON.generate#1552pascaltozzi wants to merge 1 commit intoelastic:mainfrom
pascaltozzi wants to merge 1 commit intoelastic:mainfrom
Conversation
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
|
I just monkey patched my app because this one is not merged yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This is a non-functional refactor with no behavioral changes.
As of version 2.11.0 of the
jsongem,JSON.fast_generatehas been deprecated because it provides no measurable performance benefit overJSON.generate.Why is it important?
It remove deprecation warnings and maintain forward compatibility.
Checklist