feat(ampcc): add ability to authenticate if not authenticated #1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiyasmohd
reviewed
Jan 22, 2026
shiyasmohd
reviewed
Jan 22, 2026
shiyasmohd
requested changes
Jan 22, 2026
Contributor
shiyasmohd
left a comment
shiyasmohd
left a comment
There was a problem hiding this comment.
Implementation looks nice, and works smooth. Some changes needed
- Added in comments
- Can we remove the merge commit and rebase the branch?
- There is a lag when selecting pane using mouse click, that needs to be fixed
shiyasmohd
changed the title
cmwhited
force-pushed
the
chris.whited/ampcc/feat-auth
branch
from
d7038bc to
acdae2e
Compare
shiyasmohd
approved these changes
Jan 23, 2026
Contributor
shiyasmohd
left a comment
shiyasmohd
left a comment
There was a problem hiding this comment.
LGTM ✅ Auth flow looks very nice!
- Added one more comment
- We can disable selecting pane using mouse click temporarily. To do this, you can change to
DisableMouseCapturehere
cmwhited
force-pushed
the
chris.whited/ampcc/feat-auth
branch
from
c884bf0 to
7861c45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the auth flow in ampcc to enable authenticating using the PKCE device flow against the platform auth ui.
Auth state/flow:
AMP_AUTH_TOKENto the env{home_dir}/.amp/cache/amp_cli_auth, which is set by the amp cli (and now this TUI as well)CleanShot.2026-01-20.at.12.24.04.mp4