Migrate 10 tests to JUnit 5 using CloseTestWindowsExtension #3612
+154
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogella
commented
Dec 28, 2025
| public final CloseTestWindowsRule closeTestWindowsRule = new CloseTestWindowsRule(); | ||
|
|
||
| @Rule | ||
| public final PreferenceMementoRule preferenceMemento = new PreferenceMementoRule(); |
Contributor
Author
There was a problem hiding this comment.
This one should also be migrated to Junit 5
Contributor
Author
|
PreferenceMementoRule should also be migrated to Junit 5 |
Contributor
Test Results 3 015 files 3 015 suites 2h 9m 13s ⏱️ For more details on these failures and errors, see this check. Results for commit ef718b0. ♻️ This comment has been updated with latest results. |
vogella
force-pushed
the
migrate-closetestwindows-junit5-part2
branch
from
11532d5 to
53f48f9
Compare
Migrated 10 tests in org.eclipse.ui.tests from using CloseTestWindowsRule (JUnit 4) to CloseTestWindowsExtension (JUnit 5). Updates include replacing imports, annotations (@rule -> @ExtendWith, @ignore -> @disabled, @before -> @beforeeach), and updating assertion argument order.
vogella
force-pushed
the
migrate-closetestwindows-junit5-part2
branch
from
53f48f9 to
ef718b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates 10 tests in
org.eclipse.ui.testsfromCloseTestWindowsRule(JUnit 4) toCloseTestWindowsExtension(JUnit 5).Changes include:
CloseTestWindowsRulewithCloseTestWindowsExtension.@Rule->@ExtendWith,@Ignore->@Disabled,@Before->@BeforeEach.Tests migrated:
Bug43321TestBug53489TestBug44460TestBug41931TestActionExpressionTestBug40023TestBug36537TestPerspectiveSwitcherTestTextHandlerTestStickyViewManagerTest