Add Rectangle.of(Point,Point) supporting OfFloat #2907
+88
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
1 task
akoch-yatta
reviewed
Dec 23, 2025
bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/graphics/Rectangle.java
Outdated
Show resolved
Hide resolved
ShahzaibIbrahim
force-pushed
the
master-563
branch
3 times, most recently
from
eebe042 to
8ae684b
Compare
akoch-yatta
force-pushed
the
master-563
branch
from
8ae684b to
696288e
Compare
amartya4256
reviewed
Jan 2, 2026
bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/graphics/Rectangle.java
Show resolved
Hide resolved
ShahzaibIbrahim
force-pushed
the
master-563
branch
from
696288e to
8d533eb
Compare
When the size point is Point.OfFloat, return Rectangle.OfFloat to retain sub-pixel precision; otherwise return the classic Rectangle.
ShahzaibIbrahim
force-pushed
the
master-563
branch
from
8d533eb to
b701ab0
Compare
HeikoKlare
reviewed
Jan 5, 2026
| * dimensions | ||
| * @since 3.133 | ||
| */ | ||
| public static Rectangle of(Point topLeft, Point dimension) { |
Contributor
There was a problem hiding this comment.
There is already of(Point, int, int). Since that and this new method are basically equal (just that the new one can carry additional context information in the dimension point), I would expect them to behave the same whenever possible. This particularly means:
- The existing method should also properly handle the passed topleft point being OfFloat
- This new method should also deal with topLeft being WithMonitor
Comment on lines
+390
to
+393
| * If the provided {@code Point} instance carries additional OfFloat | ||
| * information, an extended {@code Rectangle} type may be returned to preserve | ||
| * that context. Otherwise, a standard {@code Rectangle} is returned. | ||
| * </p> |
Contributor
There was a problem hiding this comment.
"OfFloat" is nothing known at public API. The contract of the method should be accordingly abstract. I would propose to adopt the formulation of the existing of(Point, int, int) method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the size point is Point.OfFloat, return Rectangle.OfFloat to retain sub-pixel precision; otherwise return the classic Rectangle.
This is introduced as needed to be used in eclipse-platform/eclipse.platform.ui#3597