VMNetworkAdapter: Fix Get- failing for a ManagementOS adapter#188
Open
jberezanski wants to merge 1 commit intodsccommunity:mainfrom
Open
VMNetworkAdapter: Fix Get- failing for a ManagementOS adapter#188jberezanski wants to merge 1 commit intodsccommunity:mainfrom
jberezanski wants to merge 1 commit intodsccommunity:mainfrom
Conversation
The Get-NetworkInformation function does not work for a ManagementOS adapter and should not be called in that code path in Get-TargetResource.
Author
|
It seems the unit tests are completely broken, possibly due to breaking changes in Pester 5.x. And even if they were correct syntacticaly, most of the tests of this resource contain logic flaws. |
Member
|
We have renamed the resource, removing 'x', so please rebase this PR. |
Author
|
I never noticed the resource rename until now. I'll rework this PR soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The Get-NetworkInformation function does not work for a ManagementOS
adapter and should not be called in that code path in Get-TargetResource.
This Pull Request (PR) fixes the following issues
None
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is