chore: reference rust-lang/rust#116258#31
Merged
Tom Plant (pl4nty) merged 1 commit intoJul 18, 2026
Merged
Conversation
…ld UTF-16LE decoding Add a TODO in read_utf16le_strz linking to rust-lang/rust#116258. Once that feature stabilises, the manual code-unit reassembly + encoding_rs decode can be replaced with String::from_utf16le_lossy operating directly on the byte slice. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CeK2pahUdkd6ZXq2RsGRd3
Tom Plant (pl4nty)
changed the base branch from
main
to
feat/analyse-installshield
July 18, 2026 11:36
Tom Plant (pl4nty)
marked this pull request as ready for review
July 18, 2026 12:26
Tom Plant (pl4nty)
requested a review
from Russell Banks (russellbanks)
as a code owner
July 18, 2026 12:26
Tom Plant (pl4nty)
changed the title
Tom Plant (pl4nty)
merged commit Jul 18, 2026
d488265
into
feat/analyse-installshield
5 of 7 checks passed
Tom Plant (pl4nty)
removed the request for review
from Russell Banks (russellbanks)
July 18, 2026 12:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a 3-line
TODOcomment inread_utf16le_strz(src/analysis/installers/installshield/mod.rs) linking to rust-lang/rust#116258.Targets
feat/analyse-installshield, since the InstallShield parser this annotates lives on that branch and isn't inmainyet.Why
That issue tracks the
str_from_utf16_endianfeature, which addsString::from_utf16le/from_utf16le_lossy(and big-endian variants) that decode UTF-16 directly from a&[u8]byte slice. The InstallShield overlay parser stores filenames as UTF-16LE bytes and currently reassemblesu16code units by hand before decoding throughencoding_rs::UTF_16LE. Once the feature stabilises, that can collapse toString::from_utf16le_lossy(&buf)with noencoding_rsdependency on this path.The comment records that connection at the call site so it isn't lost. No behavioural change.
🤖 Generated with Claude Code