Notebook for BAIS2 #4
Merged
+619
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you @firzaariany . I'll give a review early next week and then we can meet to debrief. |
Contributor
Author
|
Sounds good! @emmanuelmathot |
j08lue
reviewed
Dec 15, 2025
Member
There was a problem hiding this comment.
Nit: Perhaps use in-line LaTeX $...$ for the formulae, instead of text? Just because you can, I guess - the ones you have probably look nice enough...
j08lue
reviewed
Dec 15, 2025
notebooks/sentinel/sentinel-2/fire_and_disaster_monitoring/bais2_burned_area.ipynb
Show resolved
Hide resolved
j08lue
reviewed
Dec 15, 2025
Member
There was a problem hiding this comment.
Should this be British English or AE, @emmanuelmathot?
Currently seems to be AE - "Vizualize"...
Contributor
Author
There was a problem hiding this comment.
I assume so, given the wordings in the example notebook
j08lue
reviewed
Dec 15, 2025
emmanuelmathot
approved these changes
Dec 16, 2025
Contributor
emmanuelmathot
left a comment
emmanuelmathot
left a comment
There was a problem hiding this comment.
Reviewed in pair programming with @firzaariany .Great job!
emmanuelmathot
added a commit
that referenced
this pull request
Dec 16, 2025
* readme and contrib initial commit. * Add attribution section to NDCI cyanobacteria detection notebook * Specifies how to install virtual environment * Adds files to ignore * Processes BAIS2 evalscript with openEO * Adds requirement file * Removes unused libraries * Removes UDP print * Updates text-based math formulae with latex --------- Co-authored-by: Emmanuel Mathot <[email protected]>
emmanuelmathot
added a commit
that referenced
this pull request
Dec 16, 2025
* Enhance documentation and setup instructions in README and CONTRIBUTING files; add .gitignore and pyproject.toml for project configuration and dependency management. * Notebook for BAIS2 (#4) * readme and contrib initial commit. * Add attribution section to NDCI cyanobacteria detection notebook * Specifies how to install virtual environment * Adds files to ignore * Processes BAIS2 evalscript with openEO * Adds requirement file * Removes unused libraries * Removes UDP print * Updates text-based math formulae with latex --------- Co-authored-by: Emmanuel Mathot <[email protected]> * Enhance documentation and setup instructions in README and CONTRIBUTING files; add .gitignore and pyproject.toml for project configuration and dependency management. * Update .gitignore to include additional environment and temporary file exclusions --------- Co-authored-by: Firza Riany <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
load_zarrmethod to load Sentinel-2 reflectance data as done in NDCI notebook - I might need help to navigate the items there though.requirement.txtfile includingopeneo,matplotlib,pillow, andnumpy. Let me know if additional independencies should be included.@emmanuelmathot we can talk through the notebook in a call if you're free next week?