mixing: Optimize mix message signature funcs. #3605
Merged
+126
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
changed the title
davecgh
changed the title
davecgh
reviewed
Jan 28, 2026
Member
davecgh
left a comment
davecgh
left a comment
There was a problem hiding this comment.
Nice change. That looks a lot better and refactors out the signature hash calculation which I was going to suggest or do later as well.
davecgh
approved these changes
Jan 28, 2026
jrick
commented
Jan 28, 2026
Creating the hash to verify the schnorr signature can be done without causing any allocations. This has also been moved out into a new schnorrHash helper function to reuse across both signing and verification.
davecgh
approved these changes
Jan 28, 2026
Member
davecgh
left a comment
davecgh
left a comment
There was a problem hiding this comment.
Approving again for updates to specify data for the change output and error message formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.