mixing: Avoid hash.Hash and Sum(nil) calls #3603
Merged
+32
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
reviewed
Jan 26, 2026
Member
davecgh
left a comment
davecgh
left a comment
There was a problem hiding this comment.
Nice changes. Glad to see the new zero-alloc blake256 API getting some use.
davecgh
reviewed
Jan 26, 2026
davecgh
approved these changes
Jan 26, 2026
jrick
force-pushed
the
sum256
branch
3 times, most recently
from
c395171 to
0a13a76
Compare
davecgh
approved these changes
Jan 26, 2026
Member
There was a problem hiding this comment.
Versus master:
name old alloc/op new alloc/op delta
----------------------------------------------------------------------------------
SignUtxoProof 1.06kB ± 0% 1.02kB ± 0% -3.03% (p=0.000 n=10+10)
ValidateSecp256k1P2PKH 192B ± 0% 160B ± 0% -16.67% (p=0.000 n=10+10)
name old allocs/op new allocs/op delta
-----------------------------------------------------------------------------------
SignUtxoProof 18.0 ± 0% 17.0 ± 0% -5.56% (p=0.000 n=10+10)
ValidateSecp256k1P2PKH 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=10+10)
Sum(nil) creates an unnecessary heap allocation appending the digest to the nil slice. Replace these calls with direct calls to the (*blake256.Hasher256).Sum256 method to avoid unnecessary allocations and copies. While here, use the hasher's specialized Write* methods in the utxoproof package to improve readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sum(nil) creates an unnecessary heap allocation appending the digest to the nil slice. Replace these calls with direct calls to the (*blake256.Hasher256).Sum256 method to avoid unnecessary allocations and copies.