-
Notifications
You must be signed in to change notification settings - Fork 2.2k
set unit test config.enabled to False if it is testing a disabled model #12251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12251 +/- ##
==========================================
- Coverage 91.98% 90.91% -1.07%
==========================================
Files 203 203
Lines 24981 24993 +12
==========================================
- Hits 22979 22723 -256
- Misses 2002 2270 +268
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
01cfeac to
b7a410c
Compare
b7a410c to
8ded115
Compare
7e9c594 to
8431e42
Compare
Resolves #10540
Problem
If a unit test is testing a model that is disabled, selecting it ends up in either compilation or parsing errors
Solution
If a tested model is disabled, disable the unit tests for that model as well. Even if the unit test is manually set to
enabled: truevia its own config - it should still be disabled because otherwise we'd run into graph dependency parse/compile errors as reported!Checklist