Bazel js toolchain rewrite#2206
Open
ikholopov-omni wants to merge 11 commits into
Open
Conversation
ikholopov-omni
force-pushed
the
bazel7js
branch
5 times, most recently
from
379cf44 to
665c009
Compare
rafal-hawrylak
requested changes
Jun 17, 2026
rafal-hawrylak
approved these changes
Jun 19, 2026
kolina
approved these changes
Jun 25, 2026
kolina
left a comment
kolina
left a comment
Contributor
There was a problem hiding this comment.
It makes sense to manually check that it doesn't break GCP compilation
| mode: argv.mode || "development", | ||
| target: 'node', | ||
| entry: [path.resolve(runfilesDir, workspaceName, "packages/@dataform/core/index")], | ||
| mode: argv.mode || "production", |
Contributor
There was a problem hiding this comment.
is changing default here needed?
| if (pattern instanceof RegExp) { | ||
| return pattern; | ||
| } | ||
| // If it's a string, turn it into a regex, by escaping any regex characters in the string. |
Contributor
There was a problem hiding this comment.
AI loves to remove comments :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.