Skip to content

Update NL goldens#6424

Open
ajaits wants to merge 5 commits into
datacommonsorg:masterfrom
ajaits:master
Open

Update NL goldens#6424
ajaits wants to merge 5 commits into
datacommonsorg:masterfrom
ajaits:master

Conversation

@ajaits

@ajaits ajaits commented Jul 2, 2026

Copy link
Copy Markdown
Contributor
  • update facet_ids
  • update results

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the integration test suite by refreshing the configuration files for various queries. These changes ensure that the test data remains consistent with the current data model, primarily by updating statistical variable keys and cleaning up unnecessary configuration blocks.

Highlights

  • Test Data Updates: Updated multiple integration test configuration files to reflect changes in statistical variable keys and facet IDs.
  • Configuration Cleanup: Removed redundant or deprecated chart configurations and metadata fields from several test data files to ensure consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several integration test configuration files (chart_config.json) across different test scenarios. The changes primarily involve updating statistical variable keys, facet IDs, and references to align with updated data definitions or schemas. Additionally, some unused configurations, child places, and classifications were removed from specific test data files. There are no review comments, so I have no feedback to provide.

@ajaits ajaits changed the title master Update NL goldens Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants