integration test: handle emulator to enable using spanner omni emulator for local and testing#622
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 1 minor |
🟢 Metrics 0 complexity
Metric Results Complexity 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Code Review
This pull request adds support for connecting to a local Spanner emulator in both the Java ingestion pipeline and the Python ingestion-helper workflow, including safety checks to prevent emulator usage in production environments. A review comment correctly points out that the Python Spanner client fails to override the API endpoint with the emulator host when configured, and that its production environment check is case-sensitive, which could bypass the safety guardrail.
49d494f to
9605af2
Compare
…d production safety guards
9605af2 to
3af5660
Compare
I'm working on adding an emulator based test for DCP.
prior to this PR, it was impossible to run the loader pipeline against a local Spanner emulator (like Spanner Omni) because the loader had no way to receive the emulator's port/endpoint or bypass Google Cloud authentication checks.