Skip to content

integration test: handle emulator to enable using spanner omni emulator for local and testing#622

Open
yiyche wants to merge 1 commit into
datacommonsorg:masterfrom
yiyche:feature-spanner-emulator-support
Open

integration test: handle emulator to enable using spanner omni emulator for local and testing#622
yiyche wants to merge 1 commit into
datacommonsorg:masterfrom
yiyche:feature-spanner-emulator-support

Conversation

@yiyche

@yiyche yiyche commented Jul 9, 2026

Copy link
Copy Markdown
Member

I'm working on adding an emulator based test for DCP.

prior to this PR, it was impossible to run the loader pipeline against a local Spanner emulator (like Spanner Omni) because the loader had no way to receive the emulator's port/endpoint or bypass Google Cloud authentication checks.

@yiyche yiyche requested a review from n-h-diaz July 9, 2026 02:45
@codacy-production

codacy-production Bot commented Jul 9, 2026

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 minor

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
CodeStyle 1 minor

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for connecting to a local Spanner emulator in both the Java ingestion pipeline and the Python ingestion-helper workflow, including safety checks to prevent emulator usage in production environments. A review comment correctly points out that the Python Spanner client fails to override the API endpoint with the emulator host when configured, and that its production environment check is case-sensitive, which could bypass the safety guardrail.

Comment thread pipeline/workflow/ingestion-helper/clients/spanner.py
@yiyche yiyche force-pushed the feature-spanner-emulator-support branch 2 times, most recently from 49d494f to 9605af2 Compare July 9, 2026 03:07
@yiyche yiyche force-pushed the feature-spanner-emulator-support branch from 9605af2 to 3af5660 Compare July 9, 2026 03:12
@yiyche yiyche requested a review from gmechali July 9, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant