refactor: remove legacy aggregation routes and code from ingestion-helper#614
Draft
SandeepTuniki wants to merge 1 commit into
Draft
refactor: remove legacy aggregation routes and code from ingestion-helper#614SandeepTuniki wants to merge 1 commit into
SandeepTuniki wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the entire aggregation module, including its endpoints (/aggregation/run and /aggregation/status), utilities, generators, executors, and associated unit tests from the ingestion-helper service. The README and FastAPI application configuration have been updated to reflect these removals. I have no feedback to provide as there are no review comments.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of PR #607.
All the aggregations related code is moved into
pipeline/workflow/aggregation-helperfolder.So we don't need to keep the same code in
import/pipeline/workflow/ingestion-helperand can be removed.Note: I will send this PR to review once we confirm that no other code (especially DCP related) is referencing this.