Adding golden files in cdc_nor_noninfectious#2088
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a golden summary report and a validation configuration file for US CDC non-infectious diseases, alongside updates to the manifest to integrate these validation settings. The review feedback identifies an incorrect relative path to the golden data file in the validation configuration that would lead to a failure, and suggests removing a redundant config_overrides block in the manifest.
|
Hello! I see you've tagged me. How can I help you with this pull request today? If you're looking for a review, you can use the |
|
Please add PR checklist & validation_output.csv of test run in the PR description |
Both is updated in the description, thanks @niveditasing |
PR Checklist: https://docs.google.com/spreadsheets/d/1I7nHRSI1sHniysSopogdjmzXzHrbGxY0YfMGvk8VLsM/edit?resourcekey=0-jNMx1gAtyneIlDVjm7MBjw&gid=1068957311#gid=1068957311
validation_output.csv (test run): https://pantheon.corp.google.com/storage/browser/_details/datcom-import-test/scripts/us_cdc/non_infectious_diseases/CDC_NORS_NonInfectious/2026_07_08T23_09_52_818622_07_00/input0/validation/validation_output.csv;tab=live_object?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))&project=datcom-infosys-dev