Skip to content

Adding golden files in cdc_nor_noninfectious#2088

Open
pravnkumar-cloudsufi wants to merge 4 commits into
datacommonsorg:masterfrom
cloudsufi:cdc_nors_noninfectious
Open

Adding golden files in cdc_nor_noninfectious#2088
pravnkumar-cloudsufi wants to merge 4 commits into
datacommonsorg:masterfrom
cloudsufi:cdc_nors_noninfectious

Conversation

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a golden summary report and a validation configuration file for US CDC non-infectious diseases, alongside updates to the manifest to integrate these validation settings. The review feedback identifies an incorrect relative path to the golden data file in the validation configuration that would lead to a failure, and suggests removing a redundant config_overrides block in the manifest.

Comment thread scripts/us_cdc/non_infectious_diseases/validation_config.json Outdated
Comment thread scripts/us_cdc/non_infectious_diseases/manifest.json Outdated
@pravnkumar-cloudsufi

Copy link
Copy Markdown
Author

@gemini-code-assist

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Hello! I see you've tagged me. How can I help you with this pull request today? If you're looking for a review, you can use the /gemini review command, or if you have a specific question about the changes, feel free to ask!

@hareesh-ms hareesh-ms requested a review from ajaits July 9, 2026 05:51
@niveditasing

Copy link
Copy Markdown
Contributor

Please add PR checklist & validation_output.csv of test run in the PR description

@pravnkumar-cloudsufi

Copy link
Copy Markdown
Author

Please add PR checklist & validation_output.csv of test run in the PR description

Both is updated in the description, thanks @niveditasing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants