Added historical data in gcs bucket WorldBankDatasets#2077
Open
niveditasing wants to merge 4 commits into
Open
Added historical data in gcs bucket WorldBankDatasets#2077niveditasing wants to merge 4 commits into
niveditasing wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new GCS path flag and logic to merge and deduplicate deleted historical data into the processed output. The review feedback points out that importing and using pandas introduces an unnecessary external dependency and risks silent data corruption due to automatic type inference. It is recommended to use Python's built-in csv module to safely perform the merge and deduplication instead.
niveditasing
changed the title
niveditasing
force-pushed
the
world_bank_gcs
branch
2 times, most recently
from
1817c23 to
8df2531
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New GCS Flag: Introduced historical_gcs_path : https://storage.mtls.cloud.google.com/unresolved_mcf/world_bank/datasets/deleted_historical_data_06_2026.csv
to track the location of deleted historical records.
Merge & Deduplication Logic:
* Added a try-except block to load the GCS-hosted deleted data safely.
* Concatenated fresh data and deleted historical data.
* Deduplicated records based on composite keys (indicatorcode, statvar, measurementmethod, observationabout, observationdate, unit),
prioritizing newer observations (keep='first').
* Implemented a graceful fallback to proceed with only the fresh data in case the GCS read or parsing fails.
Differ summary: https://storage.mtls.cloud.google.com/unresolved_mcf/world_bank/datasets/differ_summary.json
PR checklist: https://docs.google.com/spreadsheets/d/1BzweR9Sj58j0H2_BweGTmfE4Z1lrjPZL8u1FS0kzCeg/edit?pli=1&gid=0#gid=0