Skip to content

Conversation

@tanmay-db
Copy link
Contributor

@tanmay-db tanmay-db commented Dec 3, 2025

What changes are proposed in this pull request?

This PR adds support for unified host:

  • Separates client type from host type determination, deprecating is_account_client and replacing it with host_type and client_type properties using new HostType and ClientType
    enums
  • Adds an experimental flag to indicate if a host is unified: experimental_is_unified_host
  • Adds a workspace_id attribute to Config, which is necessary for workspace clients that talk to unified hosts
  • Adds get_unified_endpoints() function, which is used in the OIDC endpoint resolution logic to discover OAuth endpoints on unified hosts
  • Adds header injection logic in ApiClient which adds an X-Databricks-Org-Id header to requests made by workspace clients on unified hosts
  • Adds comprehensive test coverage including unit tests for host/config type detection, OIDC endpoint resolution, header injection, and integration tests

Similar to what is done for databricks/databricks-sdk-go#1307

How is this tested?

  • Unit tests
  • Manually integration tested
image - All existing integration tests pass

Note: Integration test would be added in another PR once the test infra supports spog

@tanmay-db tanmay-db changed the title [Feature] SPOG Support with Experimental Flag [Feature] Add support for Unified Host with experimental flag Dec 5, 2025
@tanmay-db tanmay-db marked this pull request as ready for review December 5, 2025 15:12
@tanmay-db tanmay-db changed the title [Feature] Add support for Unified Host with experimental flag [Feature] Add support for SPOG Host with experimental flag Dec 5, 2025
@tanmay-db tanmay-db changed the title [Feature] Add support for SPOG Host with experimental flag [Feature] Add support for Unified Host with experimental flag Dec 12, 2025
@github-actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-py

Inputs:

  • PR number: 1135
  • Commit SHA: fa365402fc79141a3400ca85d144a9487fa0f30d

Checks will be approved automatically on success.

@tanmay-db
Copy link
Contributor Author

Verified external-browser auth flow works, for existing and spog use cases, browser is opened and the further API calls are successful.

@tanmay-db tanmay-db added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit c48681c Dec 17, 2025
33 checks passed
@tanmay-db tanmay-db deleted the spog-experimental branch December 17, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants