Skip to content

Conversation

@siri-varma
Copy link
Contributor

@siri-varma siri-varma commented Dec 29, 2025

Description

Upgraded the Protobuf version to 4.x

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1590

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
@siri-varma
Copy link
Contributor Author

Integration tests are failing due to flaky test #1603

@siri-varma siri-varma marked this pull request as ready for review December 30, 2025 00:26
@siri-varma siri-varma requested review from a team as code owners December 30, 2025 00:27
@siri-varma
Copy link
Contributor Author

siri-varma commented Dec 30, 2025

@dapr/approvers-java-sdk / @dapr/maintainers-java-sdk PR ready for review. Thank you

Update Protobof version to 4.33.2 (latest)

@salaboy
Copy link
Collaborator

salaboy commented Jan 5, 2026

@siri-varma I am worried about doing this, because we the grpc netty libraries also depend on Protobuf. As far as I remember we upgraded to the version that was aligned with Spring Boot and the versions used by the Spring Boot Otel instrumentation that also uses GRPC. I wouldn't upgrade this unless we are also upgrading those dependencies. Can you check which dependencies depend on protobuf by running mvn dependency:tree

Copy link
Collaborator

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I can approve this unless we check which transitive dependencies also depend on this.

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.91%. Comparing base (d759c53) to head (9c20fa0).
⚠️ Report is 248 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1611      +/-   ##
============================================
+ Coverage     76.91%   78.91%   +2.00%     
- Complexity     1592     2073     +481     
============================================
  Files           145      227      +82     
  Lines          4843     6256    +1413     
  Branches        562      684     +122     
============================================
+ Hits           3725     4937    +1212     
- Misses          821      970     +149     
- Partials        297      349      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update protobuf to 4.x to align with Spring

2 participants