-
Notifications
You must be signed in to change notification settings - Fork 224
Adding DaprSpringBootTest and DaprSidecarContainer annotation for easier ITs authoring #1610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dapr/maintainers-java-sdk and @dapr/approvers-java-sdk could you please take a look. I think this is a really important improvement for ITs and Testcontainers integration. @salaboy and @javier-aliaga could you please take a look. Thank you. |
|
@artur-ciocanu great stuff.. as always.. I am not saying that these improvements are not good. I am just worried on going too deep into simplifications where it looks odd for spring users. For example |
@salaboy your suggestion is that we do not try to compose annotations, so we do not confuse SpringBoot users. I get your point. I wanted to make sure that we can simplify some of this random port and sidecar dependency, but I guess since we want it just for us we can push it to it as a helper, outside of the Dapr Testconainer module, what do you think? |
|
Yeah so let's split what the end user will use to create end user tests and the functionality that we want to have for our own tests to make them easier |
|
@salaboy the helper annotations and classes have been moved to "sdk-tests" module, now these should not conflict with "testcontainers-dapr" module. Let me know your thoughts. |
sdk-tests/src/test/java/io/dapr/testcontainers/spring/DaprSpringBootTest.java
Outdated
Show resolved
Hide resolved
sdk-tests/src/test/java/io/dapr/it/testcontainers/actors/DaprActorsIT.java
Show resolved
Hide resolved
…ier IT authoring. Signed-off-by: Artur Ciocanu <[email protected]> # Conflicts: # testcontainers-dapr/pom.xml
…ier IT authoring. Signed-off-by: Artur Ciocanu <[email protected]>
…posing it as public API Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
7212700 to
d301e32
Compare
|
@salaboy I have moved all the helper classes to @siri-varma and @javier-aliaga let me know your thoughts. Once this is merged I will open PRs to move other ITs to use this new approach. |
cicoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🎉
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1610 +/- ##
============================================
+ Coverage 76.91% 78.90% +1.98%
- Complexity 1592 2074 +482
============================================
Files 145 227 +82
Lines 4843 6256 +1413
Branches 562 684 +122
============================================
+ Hits 3725 4936 +1211
- Misses 821 972 +151
- Partials 297 348 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR adds two major improvements:
Currently only a single IT has been migrated to showcase how things are looking.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: