Stabilize fresh-agent transcript scroll timing#493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The flaky PageUp/PageDown failures observed
scrollTop = 1000, matching the mockedscrollHeight. The only non-user-action writer that can set the transcript scroller toscrollHeightwas the passive auto-scroll effect, which could run after the test/user had already performed an imperative page scroll.Verification
npm run test:vitest -- run test/unit/client/components/fresh-agent/__intentional_missing_file__.test.tsxexited 1 withNo test files foundnpm run test:vitest -- run test/unit/client/components/fresh-agent/FreshAgentTranscript.test.tsx -t "does not let a deferred initial auto-scroll clobber an imperative page scroll"npm run test:vitest -- run test/unit/client/components/fresh-agent/FreshAgentView.test.tsx -t "transcript keyboard scroll"npm run test:vitest -- run test/unit/client/components/fresh-agent/FreshAgentView.test.tsx test/unit/client/components/fresh-agent/FreshAgentTranscript.test.tsxFRESHELL_TEST_SUMMARY='verify fresh-agent scroll flake stabilization' npm run checkgit diff --check HEAD