Add Cylc Review (from Cylc 7) #755
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
feat.cylc-review
branch
5 times, most recently
from
befa4f2 to
f35b60c
Compare
wxtim
force-pushed
the
feat.cylc-review
branch
from
f35b60c to
02987a1
Compare
wxtim
force-pushed
the
feat.cylc-review
branch
from
4d05257 to
b781d3c
Compare
Open
1 task
wxtim
force-pushed
the
feat.cylc-review
branch
4 times, most recently
from
b528eea to
37dc894
Compare
Contributor
|
I just had a look at the macOS failures to see I could offer any help........Ooooof. |
wxtim
force-pushed
the
feat.cylc-review
branch
5 times, most recently
from
37ff40f to
f4fc283
Compare
wxtim
force-pushed
the
feat.cylc-review
branch
from
f4fc283 to
c4b0ae2
Compare
Member
Author
|
Tests will fail until other branches merged - this commit's tests shows that they should pass after those are merged. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ChrisPaulBennett
requested changes
Dec 15, 2025
Contributor
ChrisPaulBennett
left a comment
ChrisPaulBennett
left a comment
There was a problem hiding this comment.
Something is not right with the sorting of `last active time`. It appears to be backwards
wxtim
force-pushed
the
feat.cylc-review
branch
2 times, most recently
from
a8c9dae to
d960a8a
Compare
Member
Author
|
Have fixed. |
fix sort order fixed small bug in broadcast states qurey fix test
wxtim
force-pushed
the
feat.cylc-review
branch
from
57f33dc to
d766d42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes cylc/cylc-flow#5937 and cylc/cylc-flow#3441
Requires cylc/cylc-flow#7068 to work correctly (else
cylc reviewis labelled a dead-end).Sort of requires cylc/release-actions#136 To run coverage later.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).Test working can be demonstrated by adding this to CI.
https://github.com/cylc/cylc-uiserver/actions/runs/19763672460/job/56631293468
?.?.xbranch.