BUG: Address broken NEXRAD radar when key expires#8
Merged
Conversation
Root cause: redis.expire() on a non-existent key returns 0 and silently does nothing. Once the scan keys expired (for any reason — brief network glitch, Redis restart, etc.), the "data unchanged" path kept calling expire() on dead keys and skipping the re-download, permanently losing station data. Fix: refreshScanTTL now returns whether the scan key actually exists. When it returns false, the ingester clears latestVolume for that station, forcing a re-download on the same cycle. This makes NEXRAD keys self-healing — even if they expire, they'll be recreated within one poll cycle (60s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
● Summary
Changes
seconds instead of staying permanently unavailable
Testing
How did you verify this works?