Fix spec for trap_thread_dump_signal#1896
Open
eregon wants to merge 1 commit into
Open
Conversation
Contributor
|
@eregon think there's a JRuby error hre |
Author
|
Ah yes because JRuby runs the handler on a non-main Thread, I'll adjust the |
* The spec was timing-dependant and therefore flaky. * Use a common pattern guaranteed to match. * Always wait for the signal since Process.kill can be asynchronous (and in real cases always is). * See truffleruby/truffleruby#4383 (comment)
eregon
force-pushed
the
fix-trap_thread_dump_signal-spec
branch
from
July 24, 2026 21:05
8412bd8 to
2795005
Compare
Author
|
@luke-hill Done, please start the CI and take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Locally I added a
1000.times { ... }around to spec and that way I could repro the failure locally (100 was not enough).Before the fix it failed reliably a few times, after it passes reliably.
Type of change
Please delete options that are not relevant.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses