Update MessageBuilder when runner generate messages

[brasmusson]

Description

• Changes when the runner generate messages at the source.

Depend on cucumber/cucumber-ruby-core#331

Type of change

Please delete options that are not relevant.

• Refactoring (improvements to code design or tooling that don't change behaviour)
• New feature (non-breaking change which adds new behaviour)

Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

• Tests have been added for any changes to behaviour of the code
• New and existing tests are passing locally and on CI
• bundle exec rubocop reports no offenses
• RDoc comments have been updated
• CHANGELOG.md has been updated

[luke-hill]

From my understanding doesn't this "reset" always need to happen. Then line 60 can become

@current_test_case_started_id = event.envelope.test_case_started.id if event.envelope.test_case_started

[brasmusson]

It is equivalent to write line 58-63 as:

        if event.envelope.test_case_started
          @current_test_case_started_id = event.envelope.test_case_started.id
          @current_test_run_hook_started_id = nil
          @repository.update(event.envelope)
        end

but rubocop will complain "Use a guard clause (return unless event.envelope.test_case_started) instead of wrapping the code inside a conditional expression."

Another equivalent alternative is

        @current_test_case_started_id = event.envelope.test_case_started.id if event.envelope.test_case_started
        @current_test_run_hook_started_id = nil if event.envelope.test_case_started
        @repository.update(event.envelope) if event.envelope.test_case_started

but I'm not sure about using the same trailing if on three lines in a row.

[luke-hill]

I more meant this.

@current_test_case_started_id = event.envelope.test_case_started.id if event.envelope.test_case_started
@current_test_run_hook_started_id = nil
@repository.update(event.envelope)

[brasmusson]

@current_test_run_hook_started_id = nil
is completely wrong. What you get if you inline store_current_test_run_hook_started_id and snip the line that are not relevant is:

@current_test_run_hook_started_id = event.envelope.test_run_hook_started.id if event.envelope.test_run_hook_started

@current_test_run_hook_started_id = nil

@repository.update(event.envelope) is not completely wrong, but it is not necessary to update the repository with every type of message. Actually since the only usage of the repository in message_builder is:
@repository.test_step_by_id[event.test_step.id].pickle_step_id
(in generate_snippet_envelope)
@repository.update(event.envelope) is not needed at all here. It is sufficient that the repository is updated with the test_case_ready envelopes in on_test_case_ready.

This should also work:

@current_test_case_started_id = event.envelope.test_case_started.id if event.envelope.test_case_started
@current_test_run_hook_started_id = nil if event.envelope.test_case_started

[luke-hill]

Requires cucumber-core 18.1+