Skip to content

apiclient: return nil response if we couldnt connect to LAPI#4573

Merged
blotus merged 2 commits into
masterfrom
api-client-nil-resp
Jul 23, 2026
Merged

apiclient: return nil response if we couldnt connect to LAPI#4573
blotus merged 2 commits into
masterfrom
api-client-nil-resp

Conversation

@blotus

@blotus blotus commented Jul 23, 2026

Copy link
Copy Markdown
Member

Fixes #4562

@github-actions

Copy link
Copy Markdown

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions

Copy link
Copy Markdown

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus

blotus commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

/kind fix
/area agent

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.85%. Comparing base (7363888) to head (9d3f460).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiclient/client_http.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4573      +/-   ##
==========================================
- Coverage   63.86%   63.85%   -0.02%     
==========================================
  Files         509      509              
  Lines       38960    38962       +2     
==========================================
- Hits        24883    24879       -4     
- Misses      11707    11712       +5     
- Partials     2370     2371       +1     
Flag Coverage Δ
bats 41.94% <40.00%> (-0.02%) ⬇️
unit-linux 40.00% <40.00%> (+0.07%) ⬆️
unit-windows 28.62% <40.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sabban sabban left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blotus
blotus merged commit a88b497 into master Jul 23, 2026
14 of 17 checks passed
@blotus
blotus deleted the api-client-nil-resp branch July 23, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crowdsec crash (log message "invalid memory address or nil pointer dereference")

2 participants