use windowsMatchComparer for OSVersion match order#25
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Aug 21, 2025
Merged
use windowsMatchComparer for OSVersion match order#25dmcgowan merged 1 commit intocontainerd:mainfrom
dmcgowan merged 1 commit intocontainerd:mainfrom
Conversation
mweibel
force-pushed
the
windows-os-version-sort
branch
from
064fd86 to
1abe0f9
Compare
Windows OS version should match based on the full OSVersion. When sorting a manifest, the entries should be sorted using the `Less` function. Signed-off-by: Michael Weibel <[email protected]>
mweibel
force-pushed
the
windows-os-version-sort
branch
from
1abe0f9 to
8c0d9f9
Compare
|
This looks working from my testing |
kiashok
approved these changes
Aug 18, 2025
Contributor
|
@estesp @dmcgowan Is this change ok to have? Helps to match the closest OS versions on image manifest lists that have many compatible OS versions to pull from. For example, if host is on WS2025 and the image manifest list has both WS2022 and WS2025 (in that specific order), we pick Ws2025. Without this change, we would just base the decision on ordering and pick WS2022 as it comes first in the list. |
dmcgowan
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows OS version should match based on the full OSVersion. When sorting a manifest, the entries should be sorted using the
Lessfunction.This is a possible fix for containerd/containerd#11366.