Skip to content

Conversation

@ubik2
Copy link
Contributor

@ubik2 ubik2 commented Dec 12, 2025

Remove the schemaTracker entries for the modified docs, so we don't just skip evaluating them.


Summary by cubic

Clear cached schemaTracker entries for modified documents before evaluateDocumentLinks, so they’re re-evaluated instead of skipped. Fixes stale link results when docs change.

Written for commit bb7b39e. Summary will update automatically on new commits.

…emaTracker entries for the modified docs, so we don't just skip evaluating them.
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@ubik2
Copy link
Contributor Author

ubik2 commented Dec 12, 2025

I think this is more complicated than I initially thought.
We also need to make sure that the entries we added to schemaTracker get added to newFacts, and we need to add to newFacts or schemaTracker even when the fact doesn't exist (otherwise, we'll subscribe when the fact doesn't exist, and stop watching because it doesn't exist, but then when another client creates that fact, we won't see it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants