flow stream will provide module definitions for actions#1079
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2647606436 Status: Passed Job summariesrspec: [cloud]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/15153249838/artifacts/tmp/coverage/index.html rspec: [ee]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/15153249837/artifacts/tmp/coverage/index.html rspec: [ce]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/15153249836/artifacts/tmp/coverage/index.html docs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/15153330699/artifacts/out/index.html rubocop937 files inspected, no offenses detected |
| ) | ||
| end | ||
|
|
||
| def update_runtime_compatibility |
There was a problem hiding this comment.
Why are you making this sync? Ideally this would stay async with the UpdateRuntimeCompatibilityJob. This will also take care of updating the flows of the runtime.
raphael-goetz
force-pushed
the
#1052-send-module-configurations
branch
from
9e091f9 to
47e13e9
Compare
There was a problem hiding this comment.
Pull request overview
This PR extends the Flow gRPC update stream so that when a runtime connects it receives module configuration entries for all module configuration definitions (falling back to definition defaults when a project has no saved value), addressing issue #1052 (“Send ModuleConfiguration on Action Connection”).
Changes:
- Update
FlowHandler.grouped_module_configurationsto emit module configurations for every module configuration definition, using saved project values when present and defaults otherwise. - Add
ModuleConfigurationDefinition#to_default_grpcto serialize default configuration values into the same gRPC shape as saved configurations. - Add specs covering the new default-serialization behavior and the updated grouping behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/services/runtimes/grpc/modules/update_service_spec.rb | Adds coverage ensuring the modules update service schedules runtime compatibility updates. |
| spec/models/module_configuration_definition_spec.rb | Adds a spec for serializing a definition’s default value to gRPC. |
| spec/grpc/flow_handler_spec.rb | Adds coverage for mixing saved module configuration values with definition defaults in the Flow stream. |
| app/models/module_configuration_definition.rb | Introduces to_default_grpc for default-value serialization. |
| app/grpc/flow_handler.rb | Updates grouping/sending logic to include module configuration definitions (defaults) in addition to saved values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolves: #1052