Skip to content

added ghost user#1078

Open
raphael-goetz wants to merge 3 commits into
mainfrom
#923-user-deletion-fails
Open

added ghost user#1078
raphael-goetz wants to merge 3 commits into
mainfrom
#923-user-deletion-fails

Conversation

@raphael-goetz

Copy link
Copy Markdown
Member

Resolves: #923

@raphael-goetz raphael-goetz self-assigned this Jun 25, 2026
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2636379119

Status: Passed
Duration: 6 minutes

Job summaries

rspec: [cloud]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/15077030002/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2636379119/test_report
Finished in 27.9 seconds (files took 11.2 seconds to load)
1586 examples, 0 failures, 3 pending
Line Coverage: 93.21% (5973 / 6408)
[TEST PROF INFO] Time spent in factories: 00:17.286 (51.64% of total time)

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/15077030001/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2636379119/test_report
Finished in 28.74 seconds (files took 12.12 seconds to load)
1550 examples, 0 failures, 3 pending
Line Coverage: 93.4% (5820 / 6231)
[TEST PROF INFO] Time spent in factories: 00:17.694 (49.03% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/15077030000/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2636379119/test_report
Finished in 27.77 seconds (files took 13.51 seconds to load)
1500 examples, 0 failures, 3 pending
Line Coverage: 93.0% (5644 / 6069)
[TEST PROF INFO] Time spent in factories: 00:17.127 (48.47% of total time)

docs:preview

Documentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/15077080342/artifacts/out/index.html

rubocop

933 files inspected, no offenses detected

@Taucher2003 Taucher2003 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to think about this a bit more. We will need more internal users (Crater for example needs one) so we should build it in a way that can be easily extended. I think a user_type enum with values like regular and ghost would be a better implementation rather than basing it on usernames. This makes it easily extendable and we are more free on the usernames on conflicts if we add an internal user after the release.

Comment thread app/models/user.rb Outdated
Comment thread app/models/user.rb Outdated
Comment thread db/fixtures/01_application_settings.rb Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User deletion fails if user authored audit events

2 participants