spec/integration: remove github.com/ory/dockertest dependency #87
+258
−205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the dependency chain for this integration test and avoids a new go vet error observed when bumping to the latest docker libraries: ``` $ go vet /go/pkg/mod/github.com/docker/[email protected]+incompatible/opts/swarmopts/port.go:172:18: cannot range over pr.All() (value of func type iter.Seq[network.Port]): requires go1.23 or later (-lang was set to go1.16; check go.mod) ``` Now this test uses a thin wrapper around the docker cli and does not require a Go docker library + a long tail of transitive dependencies. [TNZ-72409](https://vmw-jira.broadcom.net/browse/TNZ-72409)
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
kimago
approved these changes
Dec 19, 2025
Member
kimago
left a comment
kimago
left a comment
There was a problem hiding this comment.
Reviewed changes, and successfully ran integration tests locally.
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the dependency chain for this integration test and avoids a new go vet error observed when bumping to the latest docker libraries:
Now this test uses a thin wrapper around the docker cli and does not require a Go docker library + a long tail of transitive dependencies.
TNZ-72409