Replace fixed timeout with an eventually with a higher timeout #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
Observed a test failure in a slow CI worker because the hardcoded "sleep" in this test was not long enough. Now the test polls until it observes the expected backend change - or times out.
abg
force-pushed
the
fix-flaky-status-log-test
branch
from
ca37d30 to
09d626c
Compare
Member
Author
|
Rebased to fix merge conflicts. @kimago Please review when you have a moment. |
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed a test failure in a slow CI worker because the hardcoded "sleep" in this test was not long enough.
Now the test polls until it observes the expected backend change - or times out.
Thanks for opening a PR. Please make sure you've read and followed the Contributing guide, including signing the Contributor License Agreement.
Feature or Bug Description
What does this PR change?
Motivation
Tell us about the problem you are facing, with context, that this PR solves.
Related Issue
If this PR was first opened as an issue, please provide the link to that issue here.