Skip to content

Conversation

@wobsoriano
Copy link
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2025

⚠️ No Changeset found

Latest commit: dd6ce9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
clerk-js-sandbox Skipped Skipped Dec 17, 2025 5:57am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rob/vue-unsafe-portalprovider

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment on lines +18 to +32
* <script setup>
* import { useTemplateRef } from 'vue';
* import { DialogContent } from 'reka-ui';
* import { UNSAFE_PortalProvider, UserButton } from '@clerk/vue';
*
* const dialogContentRef = useTemplateRef('dialogContentRef');
* </script>
*
* <template>
* <DialogContent ref="dialogContentRef">
* <UNSAFE_PortalProvider :getContainer="() => dialogContentRef?.$el">
* <UserButton />
* </UNSAFE_PortalProvider>
* </DialogContent>
* </template>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using Reka UI here as example (Radix in Vue ecosystem).

@wobsoriano wobsoriano marked this pull request as ready for review December 17, 2025 05:59
@alexcarpenter alexcarpenter merged commit fa6ef65 into alexcarpenter/portal-provider-3 Dec 17, 2025
6 checks passed
@alexcarpenter alexcarpenter deleted the rob/vue-unsafe-portalprovider branch December 17, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants