OKO-574 #248
Open
OKO-574 #248
+3,666
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@eldenpark Ready for review |
eldenpark
reviewed
Jan 28, 2026
| import { addStatusRoutes } from "./status"; | ||
| import { makeKeyshareRouter } from "./key_share/v1"; | ||
| import { makeKeyshareV2Router } from "./key_share_v2"; | ||
| import { makeCommitRevealRouter } from "./commit_reveal"; |
Collaborator
There was a problem hiding this comment.
Not sure why we would need yet another router. I'll modify
Collaborator
|
@chihunmanse Please review the changes I've made! |
Contributor
Author
I’ve reviewed the changes |
eldenpark
reviewed
Jan 28, 2026
| router.post("/register", bearerTokenMiddleware, keyshareV2Register); | ||
| router.post( | ||
| "/register", | ||
| commitRevealMiddleware("register"), |
Collaborator
There was a problem hiding this comment.
@chihunmanse Question. Why do we need this middleware for almost all route handlers of V2?
Contributor
Author
There was a problem hiding this comment.
@chihunmanse Question. Why do we need this middleware for almost all route handlers of V2?
Because any handler that requires OAuth authentication must ensure the OAuth token was committed and passes reveal validation before executing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
CONTRIBUTING.mdand followed the guidelines.Summary
Links (Issue References, etc, if there's any)