Skip to content

fixed bug in the orderStatus() method; changed some URLs from WAPI to… #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patric-chuzhbe wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed bug in the orderStatus() method; changed some URLs from WAPI to… #742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions node-binance-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3025,7 +3025,7 @@ let api = function Binance( options = {} ) {
orderStatus: function ( symbol, orderid, callback, flags = {} ) {
let parameters = Object.assign( { symbol: symbol }, flags );
if (orderid){
Object.assign( { orderId: orderid }, parameters )
Object.assign( parameters, { orderId: orderid } );
}

if ( !callback ) {
Expand Down Expand Up @@ -3539,10 +3539,10 @@ let api = function Binance( options = {} ) {
resolve( response );
}
}
signedRequest( wapi + 'v3/tradeFee.html', params, callback );
signedRequest( sapi + 'v1/asset/tradeFee', params, callback );
} )
} else {
signedRequest( wapi + 'v3/tradeFee.html', params, callback );
signedRequest( sapi + 'v1/asset/tradeFee', params, callback );
}
},

Expand Down Expand Up @@ -4058,7 +4058,7 @@ let api = function Binance( options = {} ) {
return promiseRequest( 'v1/marginType', params, { base:fapi, method:'POST', type:'SIGNED' } );
},

// type: 1: Add postion margin，2: Reduce postion margin
// type: 1: Add postion margin, 2: Reduce postion margin
futuresPositionMargin: async ( symbol, amount, type = 1, params = {} ) => {
params.symbol = symbol;
params.amount = amount;
Expand Down Expand Up @@ -4343,7 +4343,7 @@ let api = function Binance( options = {} ) {
return promiseRequest( 'v1/marginType', params, { base:dapi, method:'POST', type:'SIGNED' } );
},

// type: 1: Add postion margin，2: Reduce postion margin
// type: 1: Add postion margin, 2: Reduce postion margin
deliveryPositionMargin: async ( symbol, amount, type = 1, params = {} ) => {
params.symbol = symbol;
params.amount = amount;
Expand Down