Skip to content
This repository was archived by the owner on Apr 28, 2022. It is now read-only.

remove auto-adding v to the etcd image version #68

Closed
xmlking wants to merge 3 commits into
cbws:masterfrom
xmlking:master
Closed

remove auto-adding v to the etcd image version #68
xmlking wants to merge 3 commits into
cbws:masterfrom
xmlking:master

Conversation

@xmlking

@xmlking xmlking commented Mar 17, 2020

Copy link
Copy Markdown

Please read https://github.com/coreos/etcd-operator/blob/master/CONTRIBUTING.md#contribution-flow

  1. feat(tag): remove auto-adding v to the etcd image version
  2. feat(policy): add option to configure HostNetwork and DNSPolicy

@xmlking

xmlking commented Mar 17, 2020

Copy link
Copy Markdown
Author

@Marlinc following are source for the above PR.
they are very important changes for my workplace environment where they have enabled Pod Security policies and CNI. I tested then @ workplace and works as expected, Hope you will merge PR.
coreos#2079
coreos#2094

@Wouter0100

Copy link
Copy Markdown

Thanks for the PR! We'll have a look.

@Wouter0100
Wouter0100 requested a review from Marlinc June 16, 2020 09:48
@Wouter0100

Copy link
Copy Markdown

I've checked, could you please split the code in multiple merge requests? This merge request contains a lot of changes, mostly irrelevant to the MR itself.

Thanks for the time and the effort.

@Marlinc

Marlinc commented Jan 22, 2021

Copy link
Copy Markdown

Merged in 125c141

@Marlinc Marlinc closed this Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants