-
Notifications
You must be signed in to change notification settings - Fork 11.3k
fix: improve mobile responsiveness for workflows page #24257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: improve mobile responsiveness for workflows page #24257
Conversation
|
@KartikLabhshetwar is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis change updates the Workflows page header and container layout for responsiveness. It adjusts horizontal/vertical spacing, switches to flexible min-widths (min-w-0, sm:min-w-[100px]), and wraps the non-edit name display in a Tooltip. Badge styles are refined (spacing and text size). The header action area is restructured into a flex container with gap-2; delete and save buttons now explicitly use size="sm" with updated spacing. Page wrapper spacing is reduced and made responsive (px-2, sm:px-0; my-4, sm:my-8). No changes were made to data fetching, mutations, or form schema logic. Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/features/ee/workflows/pages/workflow.tsx (1)
474-474: LGTM: Button sizing and spacing improve mobile touch targets.Adding
size="sm"to both buttons makes them more compact and suitable for mobile. Thegap-2on the container provides consistent spacing.However, the
ml-3on the delete button (line 482) seems redundant given thegap-2on the parent container. Consider removing it for consistency.Apply this diff to remove the redundant margin:
color="destructive" type="button" size="sm" StartIcon="trash-2" data-testid="delete-button" - className="ml-3" onClick={() => {Also applies to: 479-479, 482-482, 494-494
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/features/ee/workflows/pages/workflow.tsx(4 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Always use
t()for text localization in frontend code; direct text embedding should trigger a warning
Files:
packages/features/ee/workflows/pages/workflow.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js
.utc()in hot paths like loops
Files:
packages/features/ee/workflows/pages/workflow.tsx
**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
Flag default exports and encourage named exports. Named exports provide better tree-shaking, easier refactoring, and clearer imports. Exempt main components like pages, layouts, and components that serve as the primary export of a module.
Files:
packages/features/ee/workflows/pages/workflow.tsx
🧬 Code graph analysis (1)
packages/features/ee/workflows/pages/workflow.tsx (1)
packages/ui/components/button/Button.tsx (1)
Button(221-349)
🔇 Additional comments (5)
packages/features/ee/workflows/pages/workflow.tsx (5)
414-414: LGTM: Responsive header padding improves mobile layout.The reduction to
px-2on mobile and restoration topx-4at thesmbreakpoint provides more usable space on small screens while maintaining the original layout on larger devices.
415-415: LGTM:min-w-0enables proper text truncation on mobile.Setting
min-w-0allows the flex container's children to shrink below their intrinsic minimum width, which is essential for truncating long workflow names. Thegap-2provides consistent spacing between elements.
440-447: LGTM: Tooltip wrapper resolves title overflow on mobile.Wrapping the workflow name in a Tooltip with
truncateand responsivemin-w-0/sm:min-w-[100px]correctly handles long titles. Users can see the full name on hover when truncated, improving the mobile experience.
463-463: LGTM: Badge styling adjustments improve mobile compactness.Reducing the left margin from
ml-4toml-2, removingmt-1, and explicitly settingtext-xsmakes badges more compact and consistently sized, which is appropriate for mobile layouts.Also applies to: 468-468
501-501: LGTM: Responsive container spacing optimizes mobile content area.Reducing vertical margin to
my-4and adding horizontal paddingpx-2on mobile provides more usable content space while preventing edge-to-edge content. Thesm:breakpoint restores the original spacing on larger screens.
|
hi @Udit-takkar can you please review this? |
Pallava-Joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
E2E results are ready! |
|
hey you don't need to keep pinging here, i've already approved the changes. the consumer team will take it from here. thanks :) |
? When I am updating the branch is it also showing you the notification? Because I have never pinged you :) |
|
@KartikLabhshetwar Hey, you don't to update branch every single time. Reviewer can do this or do it once in two/three days |
|
Hi team, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/features/ee/workflows/pages/workflow.tsx">
<violation number="1" location="packages/features/ee/workflows/pages/workflow.tsx:475">
Tooltip fallback diverges from the label’s loading state; please mirror the same conditional so the tooltip shows “loading” when data is pending.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
Pallava-Joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you address cubic suggestions
Head branch was pushed to by a user without write access
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Pallava-Joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess i tested this one already. someone from the consumer team will go through it. you can even help us by picking some medium and high priority issues though :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 12 files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
|
@dhairyashiil can you please review this once? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
What does this PR do?
Visual Demo (For contributors especially)
Video Demo (if applicable):
before:
Screen.Recording.2025-10-03.at.9.35.48.PM.mov
after:
Screen.Recording.2025-10-03.at.9.40.15.PM.mov
Mandatory Tasks (DO NOT REMOVE)