1.21.11

[rfresh2]

• fabric
• neoforge
  • unimined broken by neoforged/InstallerTools@3bbf948
• forge

download: https://nightly.link/cabaletta/baritone/actions/runs/20147447981/Artifacts.zip

[jwgalbally-eng]

#mine causes java to not respond on fabric

[rfresh2]

should be fixed now

[rfresh2]

re: neoforge

my vote is just drop support for now, and if unimined gets fixed, add it back

next mc update is no longer going to be obfuscated, so it'll need to be updated regardless

or better yet, we take the opportunity and also drop the things that make the build scripts hell - proguard, "tweaker", and "standalone". just use a standard multiloader setup

currently we can't use standard things like mixinextras, loader specific mixins, or access wideners

[mikeyisokay]

noticing a issue with when using #litematica not working.

[rfresh2]

working fine for me, would need more info

and make sure you check what you are doing works in a prev mc version

[bubbaboy8585-lab]

Is this for 1.21.11 I'm stupid? And if so do I just click download to get it for fabric

[Murat65536]

re: neoforge

my vote is just drop support for now, and if unimined gets fixed, add it back

next mc update is no longer going to be obfuscated, so it'll need to be updated regardless

or better yet, we take the opportunity and also drop the things that make the build scripts hell - proguard, "tweaker", and "standalone". just use a standard multiloader setup

currently we can't use standard things like mixinextras, loader specific mixins, or access wideners

@rfresh2
unimined/Unimined#173 Should fix this.

Concerning build scripts, Proguard also does a lot of optimization stuff, but the config hasn't been updated in a WHILE. In fact, none of them have. It's been over 2 years since there's been any gradle changes too (at least on 1.19.4, I would imagine it's different in the later version branches).

WagYourTail (person who's also behind Unimined) last updated the build scripts but I don't think that's ever happening again.

I have a PR for dependencies #4836, but it's not finished yet because I stopped working on it for a little to focus on more gameplay-related PRs.

[rfresh2]

proguard can reduce jar size slightly

but its not a significant "performance optimization", java's jit has gotten way better over the years

[ZacSharp]

My two cents on build scripts:

Removing proguard would also make stacktraces readable. Using mappings or asking for an unobfuscated stacktrace hardly ever works, so the go-to solution so far is inferring the obfuscated names based on the call structure, which is just bad. A nice side effect would be faster build times.

The size reduction achieved by proguard is actually noticeable: about 300kb saved for standalone vs unoptimized. For standalone that's 37% of the unoptimized jar size. For the fabric/forge builds the reduction is only about 17% because those contain netherpathfinder binaries. (Numbers taken from CI on the latest commit of this pull request, i.e. https://github.com/cabaletta/baritone/actions/runs/20385818803)

Tweaker (or rather tweaker:runClient) is my standard way to test things, so I'm slightly against removing it. If you think it causes too many problems, I won't try to stop you though.