Rely less on wasm-component-ld for tests
#1434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repository is often used to test experimental/upcoming features for components such as async/etc, but this creates a chicken-and-egg problem where it becomes difficult to compile tests. Many tests use upstream toolchains which use `wasm-component-ld` (e.g. Rust/C tests) but it can take time to get this updated. There's already logic to handle having tests target wasip1 and running the wit-component step manually, so this PR makes that step unconditional. This means that test binaries are always assembled with a crate-dependency of `wit-component` which should enable easier updates since it's "just" a Cargo dependency vs being part of a toolchain in a separate project.
dicej
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository is often used to test experimental/upcoming features for components such as async/etc, but this creates a chicken-and-egg problem where it becomes difficult to compile tests. Many tests use upstream toolchains which use
wasm-component-ld(e.g. Rust/C tests) but it can take time to get this updated. There's already logic to handle having tests target wasip1 and running the wit-component step manually, so this PR makes that step unconditional. This means that test binaries are always assembled with a crate-dependency ofwit-componentwhich should enable easier updates since it's "just" a Cargo dependency vs being part of a toolchain in a separate project.